Conversation
|
Why do you keep closing PRs and re-opening new ones fella? You can just force push to the existing one. I'll review this one now though. |
jamillambert
left a comment
jamillambert
left a comment
There was a problem hiding this comment.
ACK d9b50c5
Can you write a more descriptive commit message next time? Have a look at How to Write a Git Commit Message for advice.
Thanks.
|
Alright boss, thanks! |
| Some(Return::Type(_)) => true, | ||
| _ => false, | ||
| }; | ||
| let requires = matches!(method.ret, Some(Return::Type(_))); |
There was a problem hiding this comment.
Can you make this a separate patch please. Its a bit more work but good practice in writing commit logs and explaining your changes. Gives us reviewers confidence you know what you are doing and not just following the compiler blindly.
Thanks
| else if model::type_exists(version, method_name)? { | ||
| eprintln!("found model type when none expected: {}", output_method(out)); | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't personally like this lint. The first block of changes are ok-ish. The second block are definitely worse. I'd prefer to just allow the lint.
|
Hey mate, this one was fiddly enough that I decided to just do it. Thanks for you efforts though. Please see #246 if you are interested in how I went about it. |
|
Alright, thank you sir. |
3 participants
This PR fixes all Clippy lints in the
verifycrate by applying idiomatic Rust improvements and minor cleanups.