Test getzmqnotifications
#343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RPC struct exists but there is no client macro or test. The return changes in v18 and then stays the same up to v29. Add an updated struct for v18. Add the client macro, test and update the types table.
Reordering of the reexports only.
Draft
tcharding
reviewed
Aug 29, 2025
| let node = Node::with_wallet(Wallet::Default, &["-zmqpubhashblock=tcp://127.0.0.1:29000"]); | ||
|
|
||
| let list: Vec<GetZmqNotifications> = node.client.get_zmq_notifications().expect("getzmqnotifications"); | ||
| let zmq_notification = &list[0]; |
There was a problem hiding this comment.
This will panic if the list is empty. While that does prove that its not, and since its a test, panic is ok for fail. It would be nicer to use first and call unwrap or expect.
tcharding
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RPC struct exists but there is no client macro or test. The return changes in v18 and then stays the same up to v29.