Fix bitreq doc example

[jamillambert]

The example in the docs cause a random CI failure.

Change it so that it doesn't rely on example.com anymore. Add a timeout to avoid hanging.

Closes #434

[tnull]

Hmm, rather than spawning a local HTTP server, why not just do what is done in the other examples further above and simply add a no_run flag to the beginning of the example? Seems the fix could be a +1/-1 diff here?

[jamillambert]

Hmm, rather than spawning a local HTTP server, why not just do what is done in the other examples further above and simply add a no_run flag to the beginning of the example? Seems the fix could be a +1/-1 diff here?

Yeah I did think of that, but I just didn't like the idea of "fixing" example code that occasionally doesn't run by never running it. It's not a great example if we have to tell the compiler not to actually run it.

[tnull]

Hmm, rather than spawning a local HTTP server, why not just do what is done in the other examples further above and simply add a no_run flag to the beginning of the example? Seems the fix could be a +1/-1 diff here?

Yeah I did think of that, but I just didn't like the idea of "fixing" example code that occasionally doesn't run by never running it. It's not a great example if we have to tell the compiler not to actually run it.

Well, the code is not broken, it just uses an unreliable endpoint. Also note that the doctest will still be compiled, so we will notice if the API changes and it gets stale somehow.

[jamillambert]

Fair point, I prefer this fix but am happy to change it to no_run if preferred.

[tcharding]

ACK 3c0c4ce

[tcharding]

I'm not fussed either way. Merging