Refactor getblockstats tests and enable for v18
#83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
03-10-getblockstats
branch
from
f692288 to
2e9c338
Compare
The `getblockstats` method works for some versions of Core and not others. - Refactor the tests to try and make it more clear exactly when the method is tested. - Enable testing for `v18` with and without `-txindex` for versions that support it. - Enable testing of `v18` with `-txindex` - Update the rustdocs in `types` to show that its tested for `v18`. - Mine a block before getting the stats, no real reason but just because the comments mention the genesis block. FTR I'm not totally across exactly why this works for v17 and v18 and then not until v25 again.
tcharding
force-pushed
the
03-10-getblockstats
branch
from
2e9c338 to
626938c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getblockstatsmethod works for some versions of Core and not others.v18with and without-txindexfor versions that support it.v18with-txindextypesto show that its tested forv18.FTR I'm not totally across exactly why this works for v17 and v18 and then not until v25 again.