Introduce semgrep

contrib/semgrep.yml

@@ -0,0 +1,11 @@
+rules:
+
+- id: inline-from-impls
+  patterns:
+    - pattern: |-
+        impl From<$F> for $T { fn from(...) -> $SELF { ... } }
+    - pattern-not-regex: '\#\[inline\]'
+  message: Use inline attribute on `From` implementations.
+  languages:
+    - rust
+  severity: ERROR

justfile

@@ -34,3 +34,8 @@ clippy-fix:
 # Check for API changes.
 check-api:
  contrib/check-for-api-changes.sh
+
+# run `semgrep`
+semgrep:
+  env SEMGREP_ENABLE_VERSION_CHECK=0 \
+    semgrep --error --no-rewrite-rule-ids --config contrib/semgrep.yml

src/primitives/decode.rs

@@ -1041,6 +1041,7 @@ impl std::error::Error for SegwitCodeLengthError {
 }
 
 impl From<CodeLengthError> for SegwitCodeLengthError {
+    #[inline]
     fn from(e: CodeLengthError) -> Self { Self(e.encoded_length) }
 }