This repository was archived by the owner on Nov 26, 2024. It is now read-only.
v17: Add support for network methods #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support to the `v17` client and integration tests for network section methods. Note, we do not implement `into_model` for the network methods because apart from `FeeRate` there are no `rust-bitcoin` types required. Note also `getaddednodeinfo` is untested because without configuring the network it returns an empty list so a test within the current framework would be smoke and mirrors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to the
v17client and integration tests for network section methods.Note, we do not implement
into_modelfor the network methods because apart fromFeeRatethere are norust-bitcointypes required.Note also
getaddednodeinfois untested because without configuring the network it returns an empty list so a test within the current framework would be smoke and mirrors.