Skip to content

Comments

Github actions only understand full hash revs#62

Merged
tcharding merged 1 commit intorust-bitcoin:masterfrom
nyonson:fix-short-hash-bug
Feb 12, 2026
Merged

Github actions only understand full hash revs#62
tcharding merged 1 commit intorust-bitcoin:masterfrom
nyonson:fix-short-hash-bug

Conversation

@nyonson
Copy link
Collaborator

@nyonson nyonson commented Feb 12, 2026

Lesson learned, github actions only supports full hashes.

Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 15f9fc1

@tcharding tcharding merged commit ebb0d07 into rust-bitcoin:master Feb 12, 2026
11 checks passed
@nymius
Copy link
Collaborator

nymius commented Feb 12, 2026

Just a late thought, have you considered using tags?

@nyonson
Copy link
Collaborator Author

nyonson commented Feb 12, 2026

Just a late thought, have you considered using tags?

I haven't tagged anything on the rbmt side yet, but also looking ahead, rust-bitcoin uses this zizmor tool for some GA security best practices I think. It requires hashes, so might just get used to them now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants