Skip to content

Comments

Consolidate CI#65

Merged
tcharding merged 1 commit intorust-bitcoin:masterfrom
nyonson:consolidate-ci-jobs
Feb 17, 2026
Merged

Consolidate CI#65
tcharding merged 1 commit intorust-bitcoin:masterfrom
nyonson:consolidate-ci-jobs

Conversation

@nyonson
Copy link
Collaborator

@nyonson nyonson commented Feb 12, 2026

Folded the readme docs inline since those have a tendency to deviate despite our best efforts.

@nyonson nyonson force-pushed the consolidate-ci-jobs branch from d56e2ea to f2b2407 Compare February 12, 2026 23:15
@tcharding
Copy link
Member

docs and docsrs I don't mind but I'm not sold on squashing fmt and lint. Same question more or less as #64 (comment)

@nyonson
Copy link
Collaborator Author

nyonson commented Feb 16, 2026

docs and docsrs I don't mind but I'm not sold on squashing fmt and lint. Same question more or less as #64 (comment)

Yea, I might be over complicating things here. For a lot of these non-test commands, the overhead of loading up a toolchain is the majority of the "ci minutes" of the job. So was thinking for efficiency it makes sense to amortize that initialization cost for some of the tasks. But if we don't care about ci minutes or # of jobs, maybe just following the "one thing per job" rule is simple enough while also being the easiest to debug failures?

@tcharding
Copy link
Member

So was thinking for efficiency it makes sense to amortize that initialization cost for some of the tasks. But if we don't care about ci minutes

We don't, just thrash the CI machines.

or # of jobs,

In rust-bitcoin we tried to stay under 20 because that is all we get in parallel on the free tier and I personally don't like waiting for CI. But now its slow as hell still so in my head I have just given up on this goal.

maybe just following the "one thing per job" rule is simple enough while also being the easiest to debug failures?

Ease of debugging is the most important. Dev time is expensive, machine time is cheap.

@nyonson nyonson changed the title Consolidate CI jobs Consolidate CI Feb 17, 2026
@nyonson nyonson force-pushed the consolidate-ci-jobs branch 2 times, most recently from e8d455d to 3bf2281 Compare February 17, 2026 00:43
Bump rbmt version and use explicit toolchains.
@nyonson nyonson force-pushed the consolidate-ci-jobs branch from 3bf2281 to f783c1d Compare February 17, 2026 00:52
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f783c1d

@tcharding tcharding merged commit 2f26bb2 into rust-bitcoin:master Feb 17, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants