BIP375: match script_pubkey compliance with spec#79
Merged
tcharding merged 1 commit intorust-bitcoin:masterfrom Mar 19, 2026
Merged
BIP375: match script_pubkey compliance with spec#79tcharding merged 1 commit intorust-bitcoin:masterfrom
tcharding merged 1 commit intorust-bitcoin:masterfrom
Conversation
macgyver13
force-pushed
the
bip375-test-fix-bip370
branch
from
04a1853 to
9845ce0
Compare
Member
|
CI should be fixed now mate, can rebase. |
tcharding
approved these changes
Mar 18, 2026
macgyver13
force-pushed
the
bip375-test-fix-bip370
branch
from
9845ce0 to
71444bd
Compare
tcharding
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the MissingScriptPubkey check was entirely skipped when the silent-payments feature was enabled (#45, e1938eb). This was too broad — BIP375 only allows omitting PSBT_OUT_SCRIPT when a silent payment output PSBT_OUT_SP_V0_INFO is present.
Restore original bip370-parse-invalid validation behavior.