Fix getting parity from keypair in fuzzing #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also enables a test that was failung due to the parity bug.
tcharding
approved these changes
Jun 16, 2022
|
Could you explain why in other places it does check the 32'nd byte but here the 64? |
|
Or are you saying there's another place where it should be changed to 64? Do you want me to add a comment or change the commit message to explain this? |
|
That was exactly the context I've missed, Thanks! |
elichai
approved these changes
Jun 16, 2022
apoelstra
approved these changes
Jun 16, 2022
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
…r in fuzzing
f419fe884bc3a0998a2564a78b752bb24a31330d Fix getting parity from keypair in fuzzing (Tim Ruffing)
Pull request description:
This also enables a test that was failung due to the parity bug.
ACKs for top commit:
tcharding:
ACK f419fe884bc3a0998a2564a78b752bb24a31330d
elichai:
ACK f419fe884bc3a0998a2564a78b752bb24a31330d
apoelstra:
ACK f419fe884bc3a0998a2564a78b752bb24a31330d
Tree-SHA512: bec00d517495cf010c37079e3d71f1d9547a319aac50cecbca74e6d62eca7188aa79d61ee3d50ef81512c30a31b61b947e2f19e45a95b1b17a1f5cf7cf3f1019
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
…r in fuzzing
f419fe884bc3a0998a2564a78b752bb24a31330d Fix getting parity from keypair in fuzzing (Tim Ruffing)
Pull request description:
This also enables a test that was failung due to the parity bug.
ACKs for top commit:
tcharding:
ACK f419fe884bc3a0998a2564a78b752bb24a31330d
elichai:
ACK f419fe884bc3a0998a2564a78b752bb24a31330d
apoelstra:
ACK f419fe884bc3a0998a2564a78b752bb24a31330d
Tree-SHA512: bec00d517495cf010c37079e3d71f1d9547a319aac50cecbca74e6d62eca7188aa79d61ee3d50ef81512c30a31b61b947e2f19e45a95b1b17a1f5cf7cf3f1019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also enables a test that was failung due to the parity bug.