CI: Modify regex #638
Closed
CI: Modify regex #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The out of the test `test_panic_raw_ctx_should_terminate_abnormally` seems to have changed with a recent update of `cargo` causing our `grep` call to fail. The error now looks like ``` thread 'tests::test_panic_raw_ctx_should_terminate_abnormally' panicked at secp256k1-sys/src/lib.rs:904:5: [libsecp256k1] illegal argument. !rustsecp256k1_v0_8_1_fe_is_zero(&ge->x) ``` Based solely on this output and the fact that our `grep` statement used to work I conclude that the output now includes new line information. Modify the regex to do non-greedy comparison against everything before the `[libsecp256k1]` bit.
|
Wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while working on #635
The out of the test
test_panic_raw_ctx_should_terminate_abnormallyseems to have changed with a recent update ofcargocausing ourgrepcall to fail.The error now looks like
Based solely on this output and the fact that our
grepstatement used to work I conclude that the output now includes new line information.Modify the regex to do non-greedy comparison against everything before the
[libsecp256k1]bit.