fix CHANGELOG.md for 0.23.0 #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, good catch! And for what it's worth, I hate this name |
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
4b00c71c157c61d50c409e2b67e9e7935b03679a global-context-less-secure enables global-context, not the other way around (eyusufatik) Pull request description: The mentioned commit in the changelog is this: rust-bitcoin/rust-secp256k1@c1bb316 Change looks unnecessary, however, I had a minor heart-attack once I saw the changelog because we've been using the global-context feature for some time. ACKs for top commit: apoelstra: ACK 4b00c71c157c61d50c409e2b67e9e7935b03679a; successfully ran local tests Tree-SHA512: 68af4a4257abee5a92157d638fa4c7ac4855aba98b45c558adf7ae22edd478f9d50b39d2ab6f708f6b1963b84fd25127930b0e7dccc6eb0c32302b684b41e678
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
4b00c71c157c61d50c409e2b67e9e7935b03679a global-context-less-secure enables global-context, not the other way around (eyusufatik) Pull request description: The mentioned commit in the changelog is this: rust-bitcoin/rust-secp256k1@c1bb316 Change looks unnecessary, however, I had a minor heart-attack once I saw the changelog because we've been using the global-context feature for some time. ACKs for top commit: apoelstra: ACK 4b00c71c157c61d50c409e2b67e9e7935b03679a; successfully ran local tests Tree-SHA512: 68af4a4257abee5a92157d638fa4c7ac4855aba98b45c558adf7ae22edd478f9d50b39d2ab6f708f6b1963b84fd25127930b0e7dccc6eb0c32302b684b41e678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mentioned commit in the changelog is this: c1bb316
Change looks unnecessary, however, I had a minor heart-attack once I saw the changelog because we've been using the global-context feature for some time.