Rearrange tests for XOnlyPublicKey::from_slice
#785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failures are because when you compile with I think the best solution is to add these tests as a new unit test with |
|
Actually, I just saw that there is a |
…st_pubkey_from_slice
|
I did the slight refactor (without deleting any test) - feel free to merge or close as you please. |
bigspider
changed the title
XOnlyPublicKey::from_sliceXOnlyPublicKey::from_slice
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
…icKey::from_slice`
a4cb34500884721d74ce9c0111fa9ad695ed889e Reposition test_pubkey_from_bad_slice, and move failing cases from test_pubkey_from_slice (Salvatore Ingala)
Pull request description:
Adds two test cases for parsing an invalid key (despite it being 32-byte long).
Perhaps the test for `ZERO` is redundant, as `7` also has no square root, but it felt natural to add it anyway.
ACKs for top commit:
apoelstra:
ACK a4cb34500884721d74ce9c0111fa9ad695ed889e; successfully ran local tests; yeah, sure. I think this makes the tests a bit easier to follow
Tree-SHA512: f5f7f3c175c65bd9f1bb589e18246c9155d8cbed2f43ff425757222cb64fe2ec6b0e793cef500ff3e20d33135c7065fe5a835c3f4693d1b801f71fe36db25a8d
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
…icKey::from_slice`
a4cb34500884721d74ce9c0111fa9ad695ed889e Reposition test_pubkey_from_bad_slice, and move failing cases from test_pubkey_from_slice (Salvatore Ingala)
Pull request description:
Adds two test cases for parsing an invalid key (despite it being 32-byte long).
Perhaps the test for `ZERO` is redundant, as `7` also has no square root, but it felt natural to add it anyway.
ACKs for top commit:
apoelstra:
ACK a4cb34500884721d74ce9c0111fa9ad695ed889e; successfully ran local tests; yeah, sure. I think this makes the tests a bit easier to follow
Tree-SHA512: f5f7f3c175c65bd9f1bb589e18246c9155d8cbed2f43ff425757222cb64fe2ec6b0e793cef500ff3e20d33135c7065fe5a835c3f4693d1b801f71fe36db25a8d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two test cases for parsing an invalid key (despite it being 32-byte long).
Perhaps the test for
ZEROis redundant, as7also has no square root, but it felt natural to add it anyway.