Explicitly set RecoveryId value
#801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase and format this? |
At the moment its implicit in the name, make it explicit.
tcharding
force-pushed
the
06-12-recid-explicit-values
branch
from
631e595 to
6ed3a58
Compare
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
6ed3a580c1ea63ecc03dd2a5d74d2daf39c54a50 Explicitly set RecoveryId value (Tobin C. Harding)
Pull request description:
At the moment its implicit in the name, make it explicit.
Close: #777
ACKs for top commit:
apoelstra:
ACK 6ed3a580c1ea63ecc03dd2a5d74d2daf39c54a50; successfully ran local tests
Tree-SHA512: 7f44c95e57a556791433a0cc8b6e5718273e14dc5eb54bcef5ff890d117442a96324f52a9ddc198db28ce59de06ce4049379acdd83d3ad6aa5d7ac177f27d154
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
6ed3a580c1ea63ecc03dd2a5d74d2daf39c54a50 Explicitly set RecoveryId value (Tobin C. Harding)
Pull request description:
At the moment its implicit in the name, make it explicit.
Close: #777
ACKs for top commit:
apoelstra:
ACK 6ed3a580c1ea63ecc03dd2a5d74d2daf39c54a50; successfully ran local tests
Tree-SHA512: 7f44c95e57a556791433a0cc8b6e5718273e14dc5eb54bcef5ff890d117442a96324f52a9ddc198db28ce59de06ce4049379acdd83d3ad6aa5d7ac177f27d154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment its implicit in the name, make it explicit.
Close: #777