update deprecation versions and bump minor version #809
Conversation
|
As an aside, I'd like to point out how easy Basically,
You can see that even wih jj there are a lot of steps here, but git additionally insists that you push branches individually and checkout a bunch of arbitrary things while you're working. Then if I need to update these, I can similarly do an update commit, duplicate and squash it into each of the branches (will check on IRC if I can do these in one shot..), then `jj git push --remote github -b 'glob:2025-06_tbd*'`` again to push everything. |
|
Man :/ if we had done the deprecation properly we would've noticed all the uses of these deprecated functions in our unit tests and serde impls ... and then noticed that the replacements are wildly inconsistent (some take Sigh. |
|
Also the serde impls for Schnorr signatures and ECDH secrets use |
|
Ok, actually we did correct a bunch of these in 0.31. |
|
Will conflict with #806. Probably easiest to get this one in first. |
|
Heh, thanks for the ACK -- but this does not bump the minor version like it claims. |
We accidentally released 0.30.0 and 0.31.0 with "future" deprecations. Most users will not see these since the lint for them is different from the normal deprecation warning (and it's undocumented except to say that we "should not use" future deprecations, even though it works and there is no alternative). Somewhat fortunately, in 0.30.x we messed up the deprecations and provided an inconsistent and weird API to replace the old functions. But because we messed up the deprecation messages, we can pretend we didn't do it and just mark the deprecations as having started in 0.31.x
We have duplicated funny logic in the PartialOrd and Ord impls of SerializedSignature. No need to duplicate: just have PartialOrd call into Ord.
Ouch! |
Man, |
…d bump minor version
2df6636e783f194cffd248faf62b6c4da17057b6 bump version to 0.31.1 (Andrew Poelstra)
39fe6283473045b048232be35869559b22e99404 clippy: fix PartialOrd impl of SerializedSignature (Andrew Poelstra)
39feb3bac7e89434d4530932b58f4737497b6bdb update unit tests and examples to remove deprecated functions (Andrew Poelstra)
9039ae7f9082657b3612741728ba267098422a66 deprecations: replace all TBDs with 0.31.0 (Andrew Poelstra)
Pull request description:
We accidentally released 0.30.0 and 0.31.0 with "in future" deprecations. Most users will not see these since the lint for them is different from the normal deprecation warning (and it's undocumented except to say that we "should not use" future deprecations, even though it works and there is no alternative).
ACKs for top commit:
tcharding:
ACK 2df6636e783f194cffd248faf62b6c4da17057b6
Tree-SHA512: 53717ad2597dac3b616eaaf83521327b498ac848d87d11770407a75e70b51ff017feeb7fb9b5c56b6b6a3a70321c82682b1f52397cdc4b864861fa6daf5b6339
…d bump minor version
2df6636e783f194cffd248faf62b6c4da17057b6 bump version to 0.31.1 (Andrew Poelstra)
39fe6283473045b048232be35869559b22e99404 clippy: fix PartialOrd impl of SerializedSignature (Andrew Poelstra)
39feb3bac7e89434d4530932b58f4737497b6bdb update unit tests and examples to remove deprecated functions (Andrew Poelstra)
9039ae7f9082657b3612741728ba267098422a66 deprecations: replace all TBDs with 0.31.0 (Andrew Poelstra)
Pull request description:
We accidentally released 0.30.0 and 0.31.0 with "in future" deprecations. Most users will not see these since the lint for them is different from the normal deprecation warning (and it's undocumented except to say that we "should not use" future deprecations, even though it works and there is no alternative).
ACKs for top commit:
tcharding:
ACK 2df6636e783f194cffd248faf62b6c4da17057b6
Tree-SHA512: 53717ad2597dac3b616eaaf83521327b498ac848d87d11770407a75e70b51ff017feeb7fb9b5c56b6b6a3a70321c82682b1f52397cdc4b864861fa6daf5b6339
3 participants
We accidentally released 0.30.0 and 0.31.0 with "in future" deprecations. Most users will not see these since the lint for them is different from the normal deprecation warning (and it's undocumented except to say that we "should not use" future deprecations, even though it works and there is no alternative).