musig: use [u8; 32] rather than Message for musig2 messages #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The messages we sign with musig2 do not need to be pre-hashed. They just need to be 32 bytes long. To make this clearer, stop using Message.
|
Didn't you push the release just a couple hours after this? |
stevenroose
approved these changes
Jun 24, 2025
I released 0.31.1 which just updated some deprecation messages. The musig2 release will be 0.32.0 which is not released yet. |
tcharding
approved these changes
Jun 25, 2025
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
…n Message for musig2 messages
9535f629aa02cf81c32be490053b361b7d3194c7 musig: use [u8; 32] rather than Message for musig2 messages (Andrew Poelstra)
Pull request description:
The messages we sign with musig2 do not need to be pre-hashed. They just need to be 32 bytes long. To make this clearer, stop using Message.
Fixes #810.
ACKs for top commit:
tcharding:
ACK 9535f629aa02cf81c32be490053b361b7d3194c7
Tree-SHA512: 5a40c60be15d4c67032d1e5e70e7675a58f76e4a21b6c78d31ef910451de54e0c60065ca6915b5693cfb75fca733422640d804ea90b2acf6613b0c431cf8a09f
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
…n Message for musig2 messages
9535f629aa02cf81c32be490053b361b7d3194c7 musig: use [u8; 32] rather than Message for musig2 messages (Andrew Poelstra)
Pull request description:
The messages we sign with musig2 do not need to be pre-hashed. They just need to be 32 bytes long. To make this clearer, stop using Message.
Fixes #810.
ACKs for top commit:
tcharding:
ACK 9535f629aa02cf81c32be490053b361b7d3194c7
Tree-SHA512: 5a40c60be15d4c67032d1e5e70e7675a58f76e4a21b6c78d31ef910451de54e0c60065ca6915b5693cfb75fca733422640d804ea90b2acf6613b0c431cf8a09f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The messages we sign with musig2 do not need to be pre-hashed. They just need to be 32 bytes long. To make this clearer, stop using Message.
Fixes #810.