secp256k1-sys 0.8.x: fix compilation with cfg(fuzzer)
#822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confirmed by running the nostd test with cd no_std_test/ RUSTFLAGS=--cfg=fuzzing cargo +nightly-2023-12-31 run Previously this would not compile. Now it instead errors out with an "out of memory" error which I suspect is intended behavior from the fuzz infrastructure.
This will break CI even further than it's already broken (due to unpinned dependencies and compilers), because we have a check that the symbol names in libsecp256k1 match the version number in Cargo.toml. But updating these names would be a breaking change. In modern versions of rust-secp we have fixed this by not putting patch version numbers into the symbol names.
tcharding
approved these changes
Jul 8, 2025
There are no changes to |
|
Ah, yes, it is stale -- my problems with |
Correct. I think the only thing that could go wrong here is that I break compilation somehow. |
apoelstra
merged commit 139f917
into
rust-bitcoin:secp256k1-sys-0.8.x
10 of 26 checks passed
|
Tagged and published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is going to fail miserably and even compiling locally may be difficult. Reviewers should, at a minimum, verify that no code has changed except for test code (in
src/types.rs) and code gated oncfg(fuzzing).Fixes #821