-
Notifications
You must be signed in to change notification settings - Fork 305
fix: typos #823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typos #823
Conversation
|
You cannot update files in the |
@apoelstra my bad, reverted changes in depend |
|
Can you remove the commits entirely rather than reverting? My local CI will not pass if the |
I'm currently learning how to work with terminal so it's somewhat hard to do for me, may I just simply create a new PR with all the changes except depend? |
|
@crStiv you can, but simply deleting commits is pretty easy.
|
|
@apoelstra thank you so much for the detailed explanation, did I do everything right? |
|
Yep, looks good! I'll run my local test suite. (Will be 20-30 minutes; there is one other thing ahead of it in the queue.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK e33a6aa; successfully ran local tests
e33a6aa1e3cd2c7e9b78542dfd15260278127ce6 Update main.rs (crStiv)
cb48115fcb9e19adb6037729023dac1d855320c1 Update wasm.sh (crStiv)
Pull request description:
ACKs for top commit:
apoelstra:
ACK e33a6aa1e3cd2c7e9b78542dfd15260278127ce6; successfully ran local tests
Tree-SHA512: 1ee790d0c1a9484f831e4e4950dfe96a04a8b10dfb11c6257dad85be0174c0ecae356bee4aaf5d27f876e1356f154b9201ec1cc252bc8d5a220be374b472068f
e33a6aa1e3cd2c7e9b78542dfd15260278127ce6 Update main.rs (crStiv)
cb48115fcb9e19adb6037729023dac1d855320c1 Update wasm.sh (crStiv)
Pull request description:
ACKs for top commit:
apoelstra:
ACK e33a6aa1e3cd2c7e9b78542dfd15260278127ce6; successfully ran local tests
Tree-SHA512: 1ee790d0c1a9484f831e4e4950dfe96a04a8b10dfb11c6257dad85be0174c0ecae356bee4aaf5d27f876e1356f154b9201ec1cc252bc8d5a220be374b472068f
No description provided.