Skip to content

Conversation

@crStiv
Copy link
Contributor

@crStiv crStiv commented Jul 16, 2025

No description provided.

@apoelstra
Copy link
Member

You cannot update files in the depend/ directory. If you want to fix the typo in the json file you need to PR upstream to https://github.com/bitcoin-core/secp256k1/

@crStiv
Copy link
Contributor Author

crStiv commented Jul 16, 2025

You cannot update files in the depend/ directory. If you want to fix the typo in the json file you need to PR upstream to https://github.com/bitcoin-core/secp256k1/

@apoelstra my bad, reverted changes in depend

@apoelstra
Copy link
Member

Can you remove the commits entirely rather than reverting? My local CI will not pass if the depend/ directory is modified even within single commits.

@crStiv
Copy link
Contributor Author

crStiv commented Jul 16, 2025

Can you remove the commits entirely rather than reverting? My local CI will not pass if the depend/ directory is modified even within single commits.

I'm currently learning how to work with terminal so it's somewhat hard to do for me, may I just simply create a new PR with all the changes except depend?

@apoelstra
Copy link
Member

@crStiv you can, but simply deleting commits is pretty easy.

  1. Checkout your branch: git checkout typo.
  2. Run git log --oneline -6 to see your existing commits (and a couple that are already in the repo).
  3. Confirm that the commit before your changes to json has ID e33a6aa1
  4. Then move your branch: git reset --hard e33a6aa1
  5. ...and force-push: git push -f <remote name> typo

@crStiv
Copy link
Contributor Author

crStiv commented Jul 16, 2025

@apoelstra thank you so much for the detailed explanation, did I do everything right?

@apoelstra
Copy link
Member

apoelstra commented Jul 16, 2025

Yep, looks good! I'll run my local test suite. (Will be 20-30 minutes; there is one other thing ahead of it in the queue.)

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e33a6aa; successfully ran local tests

@apoelstra apoelstra merged commit 65a92ac into rust-bitcoin:master Jul 16, 2025
13 checks passed
chain-forgexcr45 added a commit to chain-forgexcr45/rust-secp256k1 that referenced this pull request Sep 28, 2025
e33a6aa1e3cd2c7e9b78542dfd15260278127ce6 Update main.rs (crStiv)
cb48115fcb9e19adb6037729023dac1d855320c1 Update wasm.sh (crStiv)

Pull request description:

  


ACKs for top commit:
  apoelstra:
    ACK e33a6aa1e3cd2c7e9b78542dfd15260278127ce6; successfully ran local tests


Tree-SHA512: 1ee790d0c1a9484f831e4e4950dfe96a04a8b10dfb11c6257dad85be0174c0ecae356bee4aaf5d27f876e1356f154b9201ec1cc252bc8d5a220be374b472068f
william2332-limf added a commit to william2332-limf/rust-secp256k1 that referenced this pull request Oct 2, 2025
e33a6aa1e3cd2c7e9b78542dfd15260278127ce6 Update main.rs (crStiv)
cb48115fcb9e19adb6037729023dac1d855320c1 Update wasm.sh (crStiv)

Pull request description:

  


ACKs for top commit:
  apoelstra:
    ACK e33a6aa1e3cd2c7e9b78542dfd15260278127ce6; successfully ran local tests


Tree-SHA512: 1ee790d0c1a9484f831e4e4950dfe96a04a8b10dfb11c6257dad85be0174c0ecae356bee4aaf5d27f876e1356f154b9201ec1cc252bc8d5a220be374b472068f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants