Skip to content

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Sep 9, 2025

In preparation for release add a changelog entry, bump the version, and update the lock files.

tcharding added a commit to tcharding/rust-bitcoin that referenced this pull request Sep 9, 2025
Based on the release tracking PR

 rust-bitcoin/rust-secp256k1#843

Just do the build errors, lint warnings done next.
tcharding added a commit to tcharding/rust-bitcoin that referenced this pull request Sep 9, 2025
Based on the release tracking PR

 rust-bitcoin/rust-secp256k1#843

Just do the build errors, lint warnings done next.
Copy link
Contributor

@stevenroose stevenroose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apoelstra
Copy link
Member

The only thing blocking this is that I would like to move the Secp256k1 object that we're using in our callback to be private (maybe I can replace it entirely with ffi::Context) and then create a new dummy Secp256k1 object where I can attempt to recreate a deprecated version of the old API.

I wouldn't mind any further API improvements but let's not block this release over it.

Copy link
Contributor

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6753b76

CHANGELOG.md Outdated
Comment on lines 15 to 21
* #811
* #794
* #797
* #798
* #802
* #803
* #805
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the other PRs in this changelog diff have links, why these don't?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, thanks man, nice one.

@apoelstra
Copy link
Member

@tcharding seems we've lost a bit of momentum here. Wanna just cut a RC (or a beta, I guess, since we know we have more changes to do) with what we've got?

@apoelstra
Copy link
Member

Steven would like to stop using a git dep in ark (git deps in Cargo have terrible interactions with Nix) and I would like to practice using this new API in p2c-s2c.

@tcharding
Copy link
Member Author

Shall we get #858 in first?

In preparation for release add a changelog entry, bump the version,
and update the lock files.
@tcharding tcharding changed the title Release tracking PR: v0.32.0 Release tracking PR: v0.32.0-beta.0 Oct 1, 2025
@tcharding tcharding marked this pull request as ready for review October 1, 2025 23:54
tcharding added a commit to tcharding/rust-bitcoin that referenced this pull request Oct 2, 2025
Based on the release tracking PR

 rust-bitcoin/rust-secp256k1#843

Just do the build errors, lint warnings done next.
tcharding added a commit to tcharding/rust-bitcoin that referenced this pull request Oct 2, 2025
Based on the release tracking PR

 rust-bitcoin/rust-secp256k1#843

Just do the build errors, lint warnings done next.
@tcharding
Copy link
Member Author

Lets leave #858 out and get this released eh?

@tcharding
Copy link
Member Author

We are good to go here, right?

tcharding added a commit to tcharding/rust-bitcoin that referenced this pull request Oct 7, 2025
Based on the release tracking PR

 rust-bitcoin/rust-secp256k1#843

Just do the build errors, lint warnings done next.
@stevenroose
Copy link
Contributor

Yes please 🙏

@apoelstra
Copy link
Member

Yes, sorry, I've just been backlogged this week.

@apoelstra
Copy link
Member

omfg, I typed "863" instead of "843" when queuing this for testing. Sorry, it's in the queue now. Two things in front of it. Should be an hour or two.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fc57f9d; successfully ran local tests

@apoelstra apoelstra merged commit 5fdf959 into rust-bitcoin:master Oct 9, 2025
42 of 43 checks passed
@apoelstra
Copy link
Member

Crap. There were FFI changes associated with this.

@tcharding we also need to release a beta version of secp256k1-sys.

Really frustrating that cargo doesn't flag this kind of thing until you actually try to publish..

@apoelstra
Copy link
Member

Neither tagged nor published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants