Delete deprecated code #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know the exact policy here in this repo but following along from `rust-bitcoin` delete all deprecated code from at least 2 releases ago - assuming the next release is going to be `v0.32.0`.
tcharding
force-pushed
the
push-xzpqvwyqmnlw
branch
from
2432bff to
dc17be4
Compare
|
All my trivial PRs are good to merge now mate, I'm guessing you were kindly waiting for #855 to go in, thanks if so. |
stevenroose
approved these changes
Sep 19, 2025
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
dc17be42b5ee6b50bfacb26524fd5637d368d1cc Delete deprecated code (Tobin C. Harding)
Pull request description:
I don't know the exact policy here in this repo but following along from `rust-bitcoin` delete all deprecated code from at least 2 releases ago - assuming the next release is going to be `v0.32.0`.
ACKs for top commit:
apoelstra:
ACK dc17be42b5ee6b50bfacb26524fd5637d368d1cc; successfully ran local tests
Tree-SHA512: 622d6d9daacfe707d4fb088b237c2aef3ed839a8b878041695e58b031b83fb4c9b8c731ebea81bf7ba941e29bcc02e5daf7266b6a632b0759c666b2c99e04b05
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
dc17be42b5ee6b50bfacb26524fd5637d368d1cc Delete deprecated code (Tobin C. Harding)
Pull request description:
I don't know the exact policy here in this repo but following along from `rust-bitcoin` delete all deprecated code from at least 2 releases ago - assuming the next release is going to be `v0.32.0`.
ACKs for top commit:
apoelstra:
ACK dc17be42b5ee6b50bfacb26524fd5637d368d1cc; successfully ran local tests
Tree-SHA512: 622d6d9daacfe707d4fb088b237c2aef3ed839a8b878041695e58b031b83fb4c9b8c731ebea81bf7ba941e29bcc02e5daf7266b6a632b0759c666b2c99e04b05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know the exact policy here in this repo but following along from
rust-bitcoindelete all deprecated code from at least 2 releases ago - assuming the next release is going to bev0.32.0.