Release tracking PR: secp256k1-sys v0.12.0
#865
+19,121
−8,207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sitting in the airport; could not work out right now what has been changed that requires this so I put a TODO in the changelog, seems reasonable since it will be the same changelog for the non-beta release. |
|
All the |
|
@tcharding you need to re-run the vendoring script to increase the version of secp256k1-sys. I think we should bump it to 0.12.0 rather than 0.12.0-beta.0 since we aren't expecting any API changes to -sys and our logic for separating symbol names in the C library doesn't handle suffixes. |
tcharding
changed the title
secp256k1-sys v0.12.0
tcharding
force-pushed
the
push-yylpyqruorro
branch
from
dc95a0c to
7df5197
Compare
In preparation for release, bump the version, add a changelog entry, and update the lock files, and run the vendor script.
I ran the script and hit enter, enter, not really understanding what it was asking.
tcharding
force-pushed
the
push-yylpyqruorro
branch
from
d675c90 to
98264f6
Compare
|
Can you put me out of my misery and tell me exactly how to run the vendor script please? I've managed to just strip the numbers out of the symbols all together. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for release, bump the version, add a TODO placeholder as a changelog, and update the lock files.