docs: fix broken link #869
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! But could you actually update this to 1.63 rather than 1.56.1? This crate might compile with 1.56.1 but that's below our MSRV and we haven't been testing it. See #864 which fixed the same blog post broken link in the main crate for the correct URL. |
Thanks for review, I updated to 1.63 |
|
Please remove the merge commit and squash your link-editing commits into one. |
radik878
force-pushed
the
fix-broken-link
branch
from
7d6c40f to
e43c899
Compare
Merged
apoelstra
added a commit
that referenced
this pull request
Oct 13, 2025
573fb55 docs: fix broken link (radik878) Pull request description: https://blog.rust-lang.org/2020/02/27/Rust-1.56.1.html - old https://blog.rust-lang.org/2022/08/11/Rust-1.63.0/"><img alt="Rustc Version 1.63.0+ - new, actual reopen #869 ACKs for top commit: apoelstra: ACK 573fb55; successfully ran local tests Tree-SHA512: 401366e6fb2f422ddfa79e235b5c00403edaabd2c521f5ad394e769f410870d3cf56f6f79c1d328c75dada4778deed4e836eff99a63f0742398b556f5cac95bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://blog.rust-lang.org/2020/02/27/Rust-1.56.1.html - this link doesn't work
https://blog.rust-lang.org/2021/11/01/Rust-1.56.1 - this link works