Skip to content

feat: Adding support for no_std environments for env_filter #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Adding support for no_std environments for env_filter #378

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
799fa34
refactor(filter): Add support for no_std environments
WolverinDEV Aug 22, 2025
a7ba807
refactor(filter): Removed std dependency from log crate
WolverinDEV Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/env_filter/Cargo.toml
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactor(filter): Add support for no_std environments

Mind fixing your commit type?

A refactor, by definition, has no user facing changes while this does. I would use feat

Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ regex = ["std", "dep:regex"]
std = []

[dependencies]
log = { version = "0.4.8", features = ["std"] }
regex = { version = "1.0.3", optional = true, default-features=false, features=["std", "perf"] }
log = { version = "0.4.8", default-features = false }
regex = { version = "1.0.3", optional = true, default-features = false, features = ["std", "perf"] }
Comment on lines +34 to +35
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this belongs in the previous comit, could you move it there?


[dev-dependencies]
snapbox = "0.6"
Expand Down
Loading