Move FAT-specific code in make_dir_in_dir (and fix .. entries) #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejpster
force-pushed
the
move-make-dir-code
branch
2 times, most recently
from
9510411 to
3c5cc62
Compare
thejpster
changed the title
thejpster
force-pushed
the
move-make-dir-code
branch
2 times, most recently
from
409dcdf to
4ecad03
Compare
Member
Author
|
Rebased on develop |
jannic
reviewed
Nov 3, 2024
This code belongs in the FAT implementation as it is all FAT-specific.
fsck was getting annoyed at this.
I ran fsck on it and it wanted to ensure we had two copies of the Volume Label - one as a volume label file in the root and one in the filesystem metadata.
thejpster
force-pushed
the
move-make-dir-code
branch
from
b17cc50 to
f497cc2
Compare
jannic
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code belongs in the FAT implementation as it is all FAT-specific.
Also fixed a bug where
..had the wrong parent cluster - both FAT16 and FAT32 should use 0 according to the complaints I was getting from fsck.Fixes #161