Skip to content

Conversation

@ValouBambou
Copy link
Contributor

@ValouBambou ValouBambou commented Feb 28, 2025

This should fix #182.

@ValouBambou ValouBambou changed the title fix #182 bad typing in defmt debug fix bad typing in defmt debug Feb 28, 2025
@thejpster
Copy link
Member

Thank you for the fix. Would you be able to amend CI so it actually builds with these logs enabled so this doesn't happen again?

@ValouBambou
Copy link
Contributor Author

I can, but it seems that the defmt-log features is already present in the matrix in the ci yaml file, so I don't know why this error has not being caught before :/

@ValouBambou
Copy link
Contributor Author

Ok I tried to investigate on why this error doesn't appear on the CI, but I cannot reproduce the issue anymore.
That's really weird because when writing this in a lib or a bin (like embassy rp blinky example) it doesn't compile:

let a = true;
defmt::info!("a = {=u8}", a);

Maybe it is a nightly issue (I updated the toolchains several times since I open the issue) but I'm not sure at all.

@thejpster
Copy link
Member

Oh. Are you/we setting DEFMT_LOG?

@ValouBambou
Copy link
Contributor Author

In my example yes with .cargo/config.toml but probably not in the CI you are right!

@thejpster thejpster added this pull request to the merge queue Mar 7, 2025
Merged via the queue into rust-embedded-community:develop with commit a17e0bc Mar 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compile error in user code when using defmt-log feature

2 participants