Fix De105Key layout: add missing AltGr keys #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpallant
approved these changes
May 14, 2025
There was a problem hiding this comment.
Seems to match https://en.wikipedia.org/wiki/German_keyboard_layout
|
Please could you add a line to https://github.com/rust-embedded-community/pc-keyboard/blob/main/CHANGELOG.md describing the change? |
|
Do I need to add more info on the change or is this enough? |
|
Perhaps mention "Add missing Alt-Gr combinations" or something? So if people think "Huh, I have keys missing from the DE105 layout in my version" it's obvious from the CHANGELOG that this next release will fix their issue. |
jonathanpallant
merged commit d532e8a
into
rust-embedded-community:main
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the keys added here are both on Wikipedia and on kbdlayout.info.
Before this it is impossible to input even
[on the De105Key layout.