Skip to content

Conversation

robamu
Copy link
Contributor

@robamu robamu commented Sep 1, 2025

I remember already changing this in a different PR.. Let's see what the GitHub CI says..

@robamu
Copy link
Contributor Author

robamu commented Sep 1, 2025

I looked at https://github.com/rust-lang/rust/blob/master/library/core/src/panic/location.rs now and the
relevant PanicInfo field seems to be col .. Weird that the tests are failing locally for me.

@robamu
Copy link
Contributor Author

robamu commented Sep 1, 2025

Oh, looked at the wrong spot:

#[stable(feature = "panic_hooks", since = "1.10.0")]
impl fmt::Debug for Location<'_> {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        f.debug_struct("Location")
            .field("file", &self.file())
            .field("line", &self.line)
            .field("column", &self.col)
            .finish()
    }
}

this was added in 1.89, while 1.88 uses a Debug derive.

@robamu robamu force-pushed the possible-test-fixes branch from ad0c860 to adb480b Compare September 1, 2025 13:50
@robamu robamu changed the title possible minor fixes for QEMU tests Bump QEMU tests Rust version to 1.89 Sep 1, 2025
@jonathanpallant jonathanpallant added this pull request to the merge queue Sep 1, 2025
Merged via the queue into main with commit 281b715 Sep 1, 2025
57 checks passed
@jonathanpallant jonathanpallant deleted the possible-test-fixes branch September 20, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants