Skip to content

Conversation

robamu
Copy link
Contributor

@robamu robamu commented Sep 8, 2025

No description provided.

@jonathanpallant
Copy link
Contributor

I guess we need to publish to know if it's worked?

@robamu
Copy link
Contributor Author

robamu commented Sep 8, 2025

I think the build failed because on a tier 3 target, the core library needs to be built.
MSP430-rt has a similar issue and build the core lib for docs.rs:

https://github.com/rust-embedded/msp430-rt/blob/master/Cargo.toml#L30

Unfortunately, this needs to be tested with a new release, yes.. should I bump the patch number in this PR as well?

Also, I wonder: Why is armv7a-none-eabihf, which is probably a lot more relevant than armv7-none-eabi (all cortex-a processors have a FPU after all), tier 3 while armv7-none-eabi is tier 2?

@jonathanpallant
Copy link
Contributor

Historical accident I guess. Or home-brew kernel people are allergic to FPUs because context switching or something. See https://github.com/thejpster/rust/tree/promote-armv7a-none-eabihf.

@robamu
Copy link
Contributor Author

robamu commented Sep 8, 2025

Ohh, that's good to know.

I skimmed https://doc.rust-lang.org/beta/rustc/target-tier-policy.html#tier-2-target-policy . Does this somehow have to be integrated into the rustc CI?

@jonathanpallant
Copy link
Contributor

Infra will do that I think. Or someone will tell me how to do it when I open the PR. It needs to be added to rustup too.

@jonathanpallant
Copy link
Contributor

This is fine - can you do the release? In theory it's just a cargo publish and then a git tag and a git push --tags.

@robamu robamu force-pushed the try-fixing-cortex-a-rt-docs branch from fa1ab69 to 45f4b81 Compare September 8, 2025 21:02
@robamu robamu added this pull request to the merge queue Sep 8, 2025
Merged via the queue into main with commit 71967ed Sep 8, 2025
57 checks passed
@robamu robamu deleted the try-fixing-cortex-a-rt-docs branch September 8, 2025 21:13
@jonathanpallant
Copy link
Contributor

nice - that worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants