Fix stack end placement #578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stack end / heap start is placed just after `.uninit` section. It is fine until a custom section is placed just after the `.uninit` section. If application places a custom section just after the `.uninit` section, there is a collision of the custom section and heap start / stack end. There is still a solution since both `__sheap` and `_stack_end` are designed to be overrided by an application, but changing their placement in the proposed way can save some debugging time. Proposed fix does not change behavior if no custom section added.
jonathanpallant
approved these changes
Apr 14, 2025
|
Looks good to me. @adamgreig ? |
|
Yep, LGTM. Thanks @tlevora. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stack end / heap start is placed just after
.uninitsection. It is fine until a custom section is placed just after the.uninitsection. If application places a custom section just after the.uninitsection, there is a collision of the custom section and heap start / stack end.There is still a solution since both
__sheapand_stack_endare designed to be overrided by an application, but changing their placement in the proposed way can save some debugging time. Proposed fix does not change behavior if no custom section added.