-
Notifications
You must be signed in to change notification settings - Fork 177
Add skip-data-init feature to disable .data section initialization #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KushalMeghani1644
wants to merge
3
commits into
rust-embedded:master
Choose a base branch
from
KushalMeghani1644:add_skip_data_copy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+68
−0
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
//! Example demonstrating the skip-data-init feature | ||
//! | ||
//! This feature is useful when using bootloaders (like RP2040's boot2) that: | ||
//! 1. Copy all data from Flash to RAM | ||
//! 2. Unmap the Flash from memory space | ||
//! 3. Jump to the Reset handler | ||
//! | ||
//! In such scenarios, the default cortex-m-rt data initialization would fail | ||
//! because it tries to copy from Flash which is no longer accessible. | ||
//! | ||
//! To use this feature, enable it in your Cargo.toml: | ||
//! ```toml | ||
//! [dependencies] | ||
//! cortex-m-rt = { version = "0.7", features = ["skip-data-init"] } | ||
//! ``` | ||
//! | ||
//! And ensure your bootloader or linker script properly initializes .data before | ||
//! jumping to Reset. | ||
#![no_main] | ||
#![no_std] | ||
|
||
use panic_halt as _; | ||
|
||
use cortex_m_rt::entry; | ||
|
||
static mut COUNTER: u32 = 42; | ||
|
||
#[entry] | ||
fn main() -> ! { | ||
unsafe { | ||
COUNTER += 1; | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you just print the counter using semihosting printout? Also, what about panicking if the output is not the expected value? |
||
loop { | ||
cortex_m::asm::nop(); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be put into local scope or replaced by an atomic to avoid unsafe code?