Skip to content

Add the simplest heap #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

JalonWong
Copy link

@JalonWong JalonWong commented Aug 15, 2025

It's very useful on a resource-constrained platform and avoids the need to use heapless modules. Its usage is the same as other heaps.
Because it's the simplest implementation, it doesn't free memory. Any memory you drop cannot be reused (it's leaked), so avoid dropping anything whenever possible.

@JalonWong JalonWong requested a review from a team as a code owner August 15, 2025 17:37
@JalonWong JalonWong force-pushed the simplest branch 3 times, most recently from 5da8355 to c5c6b52 Compare August 15, 2025 18:00
@zeenix
Copy link

zeenix commented Aug 15, 2025

@JalonWong ?

@JalonWong
Copy link
Author

JalonWong commented Aug 15, 2025

@JalonWong ?

@zeenix Sorry, I will open the PR again when I fix CI errors.

@zeenix
Copy link

zeenix commented Aug 15, 2025

@JalonWong ?

@zeenix Sorry, I will open the PR again when I fix CI errors.

Thanks. Please also provide a bit of rationale/use case in the PR description and commit messages while you're at it. 🙏

@JalonWong
Copy link
Author

@zeenix I have fixed all errors. But I'm not familiar with the permission of GitHub PR. Should I create a new one, or how can I reopen it?
I will add more descriptions later.

@zeenix
Copy link

zeenix commented Aug 16, 2025

But I'm not familiar with the permission of GitHub PR. Should I create a new one, or how can I reopen it?

I don't have permission to re-open either. I guess it's a bit too late. You shouldn't have closed the new PR. It was already there so we end up with every more noise. :( Anyway, please keep in mind in the future to do you best to reduce noise and number of PRs.

@zeenix
Copy link

zeenix commented Aug 16, 2025

I guess it's a bit too late.

I meant here that you'll need to create another PR (but let's not close that one 😉).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants