Add defmt feature to embedded-can Cargo.toml#720
Closed
dymk wants to merge 1 commit intorust-embedded:masterfrom
Closed
Add defmt feature to embedded-can Cargo.toml#720dymk wants to merge 1 commit intorust-embedded:masterfrom
defmt feature to embedded-can Cargo.toml#720dymk wants to merge 1 commit intorust-embedded:masterfrom
Conversation
Member
|
simply having the dependency be optional does create an implicit feature to enable it :) |
Author
|
Oops, that's embarrassing - I was on v0.4.1 of embedded-can which doesn't have the I see this is something others have ran into in the issue tracker - I'll toss another vote out there for a release of embedded-can, looks like it's been a while since there's been one. For now, I'll use git as the package source in my cargo.toml. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order for the
defmtdep to be used, it needs to be enabled by a feature (in this case, of the same name). As far as I can tell, simply having the dependency be optional does not create an implicit feature to enable it.