fix and check compilation with no features #876
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannic
reviewed
Oct 23, 2024
| pub html_url: Option<url::Url>, | ||
| /// Path to YAML file with chip-specific settings | ||
| #[cfg(feature = "yaml")] | ||
| pub settings: Option<PathBuf>, |
There was a problem hiding this comment.
I think this would just ignore the settings file, even if it is configured, correct?
Wouldn't it be better to report an error instead, like I implemented in #877?
jannic
reviewed
Oct 23, 2024
| with: | ||
| key: ${{ matrix.TARGET }} | ||
|
|
||
| - run: cargo check --target ${{ matrix.TARGET }} --no-default-features |
There was a problem hiding this comment.
Good idea, I copied this over to #877 (with you as the commit author), hope that's ok,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #875