Skip to content

edition flag, unsafe(no_mangle) #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025
Merged

edition flag, unsafe(no_mangle) #891

merged 2 commits into from
Aug 14, 2025

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Dec 11, 2024

Fix compilation on nightly, but bumps Rust to 1.82

cc @Emilgardis

@burrbull burrbull requested a review from a team as a code owner December 11, 2024 20:35
@burrbull
Copy link
Member Author

Alternative is to just force edition 2021 in CI

@Emilgardis
Copy link
Member

I think specifying 2021 is the way to go for now

@burrbull
Copy link
Member Author

I think specifying 2021 is the way to go for now

#892

@burrbull burrbull marked this pull request as draft December 14, 2024 16:59
@burrbull burrbull changed the title unsafe no-mangle edition flag, unsafe(no_mangle) Aug 14, 2025
@burrbull burrbull marked this pull request as ready for review August 14, 2025 15:45
@burrbull
Copy link
Member Author

/ci diff pr --current " --edition=2024"

Copy link

Diff for comment

@burrbull
Copy link
Member Author

cc @Emilgardis includes #933

Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@burrbull burrbull added this pull request to the merge queue Aug 14, 2025
Merged via the queue into master with commit 0f42ae3 Aug 14, 2025
59 checks passed
@burrbull burrbull deleted the unsafe-attr branch August 14, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants