Skip to content

Handle old LLVM pass manager on rustc 1.57 #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 22, 2021
Merged

Handle old LLVM pass manager on rustc 1.57 #197

merged 2 commits into from
Dec 22, 2021

Conversation

smoelius
Copy link
Member

@smoelius smoelius commented Dec 16, 2021 •
edited
Loading

The new LLVM pass manager was not enabled in rustc 1.57 as expected: rust-lang/rust#91263

The proposed fix to only pass -C passes=sancov-module to nightly compilers for which the LLVM version is >= 13.

Closes #192

@taiki-e Perhaps you could look this over.

taiki-e
taiki-e approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@smoelius
Copy link
Member Author

Thanks a lot, @taiki-e.

@smoelius smoelius merged commit 019f8c3 into rust-fuzz:master Dec 22, 2021
@smoelius smoelius mentioned this pull request Dec 22, 2021
Closed
@taiki-e taiki-e mentioned this pull request Jan 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@taiki-e taiki-e taiki-e approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unknown pass name 'sancov'
2 participants
@smoelius @taiki-e