Remove archive #656
Merged
Remove archive #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoelius
force-pushed
the
remove-archive
branch
from
4f1d0fc to
35de231
Compare
smoelius
force-pushed
the
remove-archive
branch
from
35de231 to
375e433
Compare
smoelius
commented
Sep 26, 2025
| -L {} ", | ||
| common::afl_llvm_dir().unwrap().display() | ||
| "-Clink-arg={} ", | ||
| common::object_file_path().unwrap().display() |
There was a problem hiding this comment.
@vanhauser-thc This is the change I am least certain about. Perhaps you could give this a glance.
I'm going to run some more tests, but the fact that CI is passing is a good sign.
There was a problem hiding this comment.
this is how you would do it with an object file instead of an archive. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate the use of archives as per @vanhauser-thc's comment here: #655 (comment)