style: word wrap code to prevent content overflow-x#1474
Closed
peterpeterparker wants to merge 2 commits intorust-lang:masterfrom
Closed
style: word wrap code to prevent content overflow-x#1474peterpeterparker wants to merge 2 commits intorust-lang:masterfrom
peterpeterparker wants to merge 2 commits intorust-lang:masterfrom
Conversation
This was referenced Feb 5, 2025
Turbo87
reviewed
Feb 5, 2025
| overflow: auto; | ||
| } | ||
|
|
||
| ul a code { |
Member
There was a problem hiding this comment.
this seems like quite a specific selector 😅
while this would probably fix the issue for the specific blog post you took a screenshot of, I assume it won't work for ol lists, for code blocks that are not links, and for code blocks that are not in lists.
do you think we can find a solution that would work for all of these cases? :)
Contributor
Author
There was a problem hiding this comment.
Fair point, I agree with you. That was a quick fix. I'll make a note and tackle this properly when I have more time. Meanwhile, I'll close the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While I reverted #1473—a change originally intended to prevent overflow-x on mobile—I noticed that, despite CSS evolving, the issue still occasionally occurs when a code block inside a link within a list has text long enough to overflow the screen. Wrapping the text forces it to break onto a new line.
Before:
After: