Open
Conversation
This was added in rust-lang#1566, but hasn't seen significant usage, so per the discussion in rust-lang#1796 let's remove it.
Contributor
|
The themes don't actually seem to work yet. |
Contributor
Author
Interesting. What are you seeing? (Or not seeing.) |
Contributor
|
Just regular, unhighlighted, "black on white" text. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the discussion in #1796, this PR updates the blog to use Zola 0.22. As part of that, the
textsyntax has been removed, and the built-inlight-plusanddark-plussyntax highlighting themes are now used.The snapshot test diffs here are going to look horrific, but spot checking a few blog pages in practice reveals only a couple of apparent differences:
The second change actually slightly improves the WCAG contrast scores. The first one makes no effective difference, although I personally miss the colour.
I obviously have no way to test the GitHub action changes, so we'll just have to see what happens. It works locally if I recreate the steps in a
rust:1.91.1Docker container. 🤷Rendered