-
Notifications
You must be signed in to change notification settings - Fork 2.7k
chore: dogfood Cargo -Zlints
table feature
#12178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1539b3d
870f9ea
7a4754a
48ccb1d
68af509
e2f5925
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -106,6 +106,20 @@ varisat = "0.2.2" | |
walkdir = "2.4.0" | ||
windows-sys = "0.48" | ||
|
||
[workspace.lints.rust] | ||
rust_2018_idioms = "warn" # TODO: could this be removed? | ||
|
||
[workspace.lints.rustdoc] | ||
private_intra_doc_links = "allow" | ||
|
||
[workspace.lints.clippy] | ||
all = { level = "allow", priority = -1 } | ||
dbg_macro = "warn" | ||
disallowed_methods = "warn" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm assuming we'll either
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The second one seems easier, though I assume most
weihanglo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
print_stderr = "warn" | ||
print_stdout = "warn" | ||
self_named_module_files = "warn" | ||
|
||
[package] | ||
name = "cargo" | ||
version = "0.77.0" | ||
|
@@ -234,3 +248,6 @@ vendored-openssl = ["openssl/vendored"] | |
vendored-libgit2 = ["libgit2-sys/vendored"] | ||
# This is primarily used by rust-lang/rust distributing cargo the executable. | ||
all-static = ['vendored-openssl', 'curl/static-curl', 'curl/force-system-lib-on-osx'] | ||
|
||
[lints] | ||
workspace = true |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,3 +32,6 @@ harness = false | |
[[bench]] | ||
name = "global_cache_tracker" | ||
harness = false | ||
|
||
[lints] | ||
workspace = true |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
#![allow(clippy::disallowed_methods)] | ||
|
||
use cargo::Config; | ||
use std::fs; | ||
use std::path::{Path, PathBuf}; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,3 +12,6 @@ publish = false | |
|
||
[lib] | ||
proc-macro = true | ||
|
||
[lints] | ||
workspace = true |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
#![allow(clippy::disallowed_methods)] | ||
|
||
fn main() { | ||
println!( | ||
"cargo:rustc-env=NATIVE_ARCH={}", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
#![allow(clippy::all)] | ||
|
||
use std::collections::BTreeMap; | ||
use std::fs::File; | ||
use std::io::prelude::*; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[package] | ||
name = "home" | ||
version = "0.5.8" | ||
version = "0.5.9" | ||
authors = ["Brian Anderson <[email protected]>"] | ||
rust-version = "1.70.0" # MSRV:3 | ||
documentation = "https://docs.rs/home" | ||
|
@@ -18,3 +18,6 @@ description = "Shared definitions of home directories." | |
|
||
[target.'cfg(windows)'.dependencies] | ||
windows-sys = { workspace = true, features = ["Win32_Foundation", "Win32_UI_Shell"] } | ||
|
||
[lints] | ||
workspace = true |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,3 +17,6 @@ url.workspace = true | |
|
||
[dev-dependencies] | ||
pretty_assertions.workspace = true | ||
|
||
[lints] | ||
workspace = true |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#![allow(clippy::all)] | ||
#![allow(clippy::print_stderr)] | ||
|
||
use std::cell::RefCell; | ||
use std::cmp::PartialEq; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,3 +10,6 @@ publish = false | |
|
||
[dependencies] | ||
tempfile.workspace = true | ||
|
||
[lints] | ||
workspace = true |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,3 +6,6 @@ edition.workspace = true | |
publish = false | ||
|
||
[dependencies] | ||
|
||
[lints] | ||
workspace = true |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,6 @@ publish = false | |
|
||
[dependencies] | ||
toml_edit.workspace = true | ||
|
||
[lints] | ||
workspace = true |
Uh oh!
There was an error while loading. Please reload this page.