Skip to content

Add initial integration for --json=timings behing -Zsection-timings #15780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/cargo/core/compiler/job_queue/job_state.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ use cargo_util::ProcessBuilder;
use crate::CargoResult;
use crate::core::compiler::build_runner::OutputFile;
use crate::core::compiler::future_incompat::FutureBreakageItem;
use crate::core::compiler::timings::SectionTiming;
use crate::util::Queue;

use super::{Artifact, DiagDedupe, Job, JobId, Message};
Expand Down Expand Up @@ -143,6 +144,10 @@ impl<'a, 'gctx> JobState<'a, 'gctx> {
.push(Message::Finish(self.id, Artifact::Metadata, Ok(())));
}

pub fn on_section_timing_emitted(&self, section: SectionTiming) {
self.messages.push(Message::SectionTiming(self.id, section));
}

/// Drives a [`Job`] to finish. This ensures that a [`Message::Finish`] is
/// sent even if our job panics.
pub(super) fn run_to_finish(self, job: Job) {
Expand Down
6 changes: 5 additions & 1 deletion src/cargo/core/compiler/job_queue/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ pub use self::job::{Job, Work};
pub use self::job_state::JobState;
use super::build_runner::OutputFile;
use super::custom_build::Severity;
use super::timings::Timings;
use super::timings::{SectionTiming, Timings};
use super::{BuildContext, BuildPlan, BuildRunner, CompileMode, Unit};
use crate::core::compiler::descriptive_pkg_name;
use crate::core::compiler::future_incompat::{
Expand Down Expand Up @@ -374,6 +374,7 @@ enum Message {
Token(io::Result<Acquired>),
Finish(JobId, Artifact, CargoResult<()>),
FutureIncompatReport(JobId, Vec<FutureBreakageItem>),
SectionTiming(JobId, SectionTiming),
}

impl<'gctx> JobQueue<'gctx> {
Expand Down Expand Up @@ -714,6 +715,9 @@ impl<'gctx> DrainState<'gctx> {
let token = acquired_token.context("failed to acquire jobserver token")?;
self.tokens.push(token);
}
Message::SectionTiming(id, section) => {
self.timings.unit_section_timing(id, &section);
}
}

Ok(())
Expand Down
19 changes: 19 additions & 0 deletions src/cargo/core/compiler/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ use self::output_depinfo::output_depinfo;
use self::output_sbom::build_sbom;
use self::unit_graph::UnitDep;
use crate::core::compiler::future_incompat::FutureIncompatReport;
use crate::core::compiler::timings::SectionTiming;
pub use crate::core::compiler::unit::{Unit, UnitInterner};
use crate::core::manifest::TargetSourcePath;
use crate::core::profiles::{PanicStrategy, Profile, StripInner};
Expand All @@ -104,6 +105,7 @@ use cargo_util_schemas::manifest::TomlDebugInfo;
use cargo_util_schemas::manifest::TomlTrimPaths;
use cargo_util_schemas::manifest::TomlTrimPathsValue;
use rustfix::diagnostics::Applicability;
pub(crate) use timings::CompilationSection;

const RUSTDOC_CRATE_VERSION_FLAG: &str = "--crate-version";

Expand Down Expand Up @@ -1095,6 +1097,12 @@ fn add_allow_features(build_runner: &BuildRunner<'_, '_>, cmd: &mut ProcessBuild
///
/// [`--error-format`]: https://doc.rust-lang.org/nightly/rustc/command-line-arguments.html#--error-format-control-how-errors-are-produced
fn add_error_format_and_color(build_runner: &BuildRunner<'_, '_>, cmd: &mut ProcessBuilder) {
let enable_timings = build_runner.bcx.gctx.cli_unstable().section_timings
&& !build_runner.bcx.build_config.timing_outputs.is_empty();
if enable_timings {
cmd.arg("-Zunstable-options");
}

cmd.arg("--error-format=json");
let mut json = String::from("--json=diagnostic-rendered-ansi,artifacts,future-incompat");

Expand All @@ -1104,6 +1112,11 @@ fn add_error_format_and_color(build_runner: &BuildRunner<'_, '_>, cmd: &mut Proc
}
_ => {}
}

if enable_timings {
json.push_str(",timings");
}

cmd.arg(json);

let gctx = build_runner.bcx.gctx;
Expand Down Expand Up @@ -1957,6 +1970,12 @@ fn on_stderr_line_inner(
return Ok(true);
}

let res = serde_json::from_str::<SectionTiming>(compiler_message.get());
if let Ok(timing_record) = res {
state.on_section_timing_emitted(timing_record);
return Ok(false);
}

// Depending on what we're emitting from Cargo itself, we figure out what to
// do with this JSON message.
match options.format {
Expand Down
Loading
Loading