Skip to content

docs: clarify that cargo:rustc-link-arg-tests only applies to integration tests #15814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: clarify that cargo:rustc-link-arg-tests only applies to integration tests #15814

wants to merge 1 commit into from
+3 −3

Conversation

t-moe
Copy link

@t-moe t-moe commented Aug 7, 2025

What does this PR try to resolve?

cargo:rustc-link-arg-tests only applies to integration test targets, not to all test targets as originally intended.

This PR updates the doc, to at least reflect what cargo:rustc-link-arg-tests currently does, until #10937 is resolved.

@rustbot
Copy link
Collaborator

rustbot commented Aug 7, 2025

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-build-scripts Area: build.rs scripts A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2025
epage
epage requested changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In documenting this, I worry this could be viewed as being prescriptive and could influence whether we can fix #10937.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epage epage epage requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@weihanglo weihanglo

Labels
A-build-scripts Area: build.rs scripts A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t-moe @rustbot @epage @weihanglo