Allow using VCToolsVersion to request a specific msvc version #1589
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodyXu
requested changes
Oct 7, 2025
| if let Some(version) = env_getter.get_env("VCToolsVersion") { | ||
| // Restrict the search to a specific msvc version; if it doesn't exist then | ||
| // our caller will fail to find the tool for this instance and move on. | ||
| return version.to_str().map(|s| s.to_string()); |
There was a problem hiding this comment.
Suggested change
| return version.to_str().map(|s| s.to_string()); | |
| return version.to_str().map(ToString::to_string) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, cc-rs always returns the latest version of the msvc tools it can find, including preview versions.
For scenarios (such as we have at Microsoft) where we want to ensure we are building with a specific version of the tools, this change makes it possible to request a specific version of the msvc tools even if a developer has other versions on their machine.