Set the MSRV to 1.65 and test this in CI #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
msrv
branch
2 times, most recently
from
9516f23 to
b173a97
Compare
Currently this crate has no clear MSRV. Pick a common ecosystem point of 1.65 (let-else!) and start testing that in CI. We could easily bump this further if needed, but there isn't much active development and it is unlikely to be a point of contributor friction. We can't easily be much below this because of `cc`.
tgross35
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this crate has no clear MSRV. Pick a common ecosystem point of 1.65 (let-else!) and start testing that in CI.
We could easily bump this further if needed, but there isn't much active development and it is unlikely to be a point of contributor friction. We can't easily be much below this because of
cc.