Pass ANDROID_ABI and ANDROID_PLATFORM environment variables#257
Open
pr2502 wants to merge 1 commit intorust-lang:mainfrom
Open
Pass ANDROID_ABI and ANDROID_PLATFORM environment variables#257pr2502 wants to merge 1 commit intorust-lang:mainfrom
pr2502 wants to merge 1 commit intorust-lang:mainfrom
Conversation
Uses environment variables as passed by cargo-ndk version 4.0 and later, and passes them as defines to cmake. Note the environment variable names as currently documented on <https://crates.io/crates/cargo-ndk> are outdated, the docs have been fixed later in <bbqsrc/cargo-ndk@1bee04b305>. fixes rust-lang#226
|
This fix targets specifically to cargo-ndk. I wonder can this package automatically infer EDIT: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses environment variables as passed by cargo-ndk version 4.0 and later, and passes them as defines to cmake. Note the environment variable names as currently documented on https://crates.io/crates/cargo-ndk are outdated, the docs have been fixed later in bbqsrc/cargo-ndk@1bee04b305.
For me this fixed issues with cross compilation to android, similar to #226.
I wasn't quite sure where to put this logic, so please let me know if you want it moved somewhere more appropriate.