libm: Reenable should_panic tests on ppc64le#1096
Merged
tgross35 merged 1 commit intorust-lang:mainfrom Feb 14, 2026
Merged
Conversation
The tests pass successfully for me on powerpc64le-unknown-linux-gnu with nightly 1.95.
Gelbpunkt
force-pushed
the
reenable-u256-overflow-test-ppc64le
branch
from
9c382cf to
1915568
Compare
Gelbpunkt
changed the title
tgross35
approved these changes
Feb 14, 2026
Contributor
tgross35
left a comment
tgross35
left a comment
There was a problem hiding this comment.
Awesome, thanks!
Any idea what the issue was?
Contributor
|
I merged 3fa5a8c a while ago, probably should have pinged you on it (sorry about that). I think I tried disabling these tests there but they still failed, so I wonder if I'm misremembering or if we got a fix since then. I'd be curious to hear your thoughts on that patch in retrospect anyway about the baseline and SIGILLs, in case I misrepresented something there. |
Contributor
Author
I think it was a QEMU bug, but I may be wrong... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests pass successfully for me on powerpc64le-unknown-linux-gnu with nightly 1.95.
Closes #835