meta: Add a root Cargo.lock file#1100
Merged
tgross35 merged 3 commits intorust-lang:mainfrom Feb 16, 2026
Merged
Conversation
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
|
If you do this, you will also have to exclude compiler-builtins from the library workspace in the rust repo. A crate may only be in one workspace at a time. |
Contributor
Author
|
There isn't any overlap currently; the compiler builtins Cargo.toml is duplicated, one for use in r-l/r and one for use here. That's because of the compiler-builtins/builtins-shim/Cargo.toml Lines 1 to 12 in bba024d |
In order to improve upon some inconsistencies seen across CI runs and locally, add a Cargo.lock file for the main workspace.
tgross35
force-pushed
the
cargo-lock
branch
2 times, most recently
from
7aeb1cb to
117b295
Compare
PRs are now getting the following:
Traceback (most recent call last):
File "/home/runner/work/compiler-builtins/compiler-builtins/ci/ci-util.py", line 510, in <module>
main()
File "/home/runner/work/compiler-builtins/compiler-builtins/ci/ci-util.py", line 496, in main
ctx.emit_workflow_output()
File "/home/runner/work/compiler-builtins/compiler-builtins/ci/ci-util.py", line 294, in emit_workflow_output
pr = PrInfo.from_env()
^^^^^^^^^^^^^^^^^
File "/home/runner/work/compiler-builtins/compiler-builtins/ci/ci-util.py", line 152, in from_env
return cls.from_pr(pr_env)
^^^^^^^^^^^^^^^^^^^
File "/home/runner/work/compiler-builtins/compiler-builtins/ci/ci-util.py", line 174, in from_pr
return cls(**json.loads(pr_info), cfg=PrCfg(pr_json["body"]))
^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/work/compiler-builtins/compiler-builtins/ci/ci-util.py", line 134, in __init__
pprint.pp(self)
File "/usr/lib/python3.12/pprint.py", line 66, in pp
pprint(object, *args, sort_dicts=sort_dicts, **kwargs)
...
AttributeError: 'PrCfg' object has no attribute 'extra_extensive'. Did you mean: 'skip_extensive'?
Resolve this by using `__post_init__` rather than `__init__`.
Fixes: bba024d ("ci: Allow specifying extra extensive tests to run")
As of indicatif 0.18.4, this option must be enabled in able to build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to improve upon some inconsistencies seen across CI runs and locally, add a Cargo.lock file for the main workspace.
ci: test-libm