Add frexpf128, ilogbf16, and ilogbf128#862
Merged
tgross35 merged 2 commits intorust-lang:mainfrom Feb 12, 2026
Merged
Conversation
0c317ce to
08d2f0b
Compare
frexpf16, frexpf128, ilogbf16, and ilogbf128frexpf128, ilogbf16, and ilogbf128
9d13db3 to
d2d2ba4
Compare
Contributor
Author
|
Current regression on aarch64 shows Previously there was a single function, but with the generic there is: Not sure why it isn't getting inlined, even |
The `frexpf16` signature is added (to make traits easier) but left unimplemented, since it will need a slightly different algorithm.
d2d2ba4 to
4accc08
Compare
Contributor
Author
|
Oh, duh, it won't inline because the generic I'm just going to accept the regression here since I'll be following up with a change to the algorithm to support f16. |
Contributor
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci: allow-regressions