Skip to content

Disable aarch64 assembly if target_abi = "softfloat" #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tgross35 wants to merge 1 commit into from
Closed

Disable aarch64 assembly if target_abi = "softfloat" #905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libm/src/math/arch/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ cfg_if! {
pub use x86::{sqrt, sqrtf, fma, fmaf};
} else if #[cfg(all(
any(target_arch = "aarch64", target_arch = "arm64ec"),
target_feature = "neon"
target_feature = "neon",
not(target_abi = "softfloat"),
))] {
mod aarch64;

Expand Down
4 changes: 2 additions & 2 deletions libm/src/math/fma.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ pub fn fmaf(x: f32, y: f32, z: f32) -> f32 {
select_implementation! {
name: fmaf,
use_arch: any(
all(target_arch = "aarch64", target_feature = "neon"),
all(target_arch = "aarch64", target_feature = "neon", not(target_abi = "softfloat")),
target_feature = "sse2",
),
args: x, y, z,
Expand All @@ -37,7 +37,7 @@ pub fn fma(x: f64, y: f64, z: f64) -> f64 {
select_implementation! {
name: fma,
use_arch: any(
all(target_arch = "aarch64", target_feature = "neon"),
all(target_arch = "aarch64", target_feature = "neon", not(target_abi = "softfloat")),
target_feature = "sse2",
),
args: x, y, z,
Expand Down
4 changes: 2 additions & 2 deletions libm/src/math/rint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ pub fn rintf(x: f32) -> f32 {
select_implementation! {
name: rintf,
use_arch: any(
all(target_arch = "aarch64", target_feature = "neon"),
all(target_arch = "aarch64", target_feature = "neon", not(target_abi = "softfloat")),
all(target_arch = "wasm32", intrinsics_enabled),
),
args: x,
Expand All @@ -34,7 +34,7 @@ pub fn rint(x: f64) -> f64 {
select_implementation! {
name: rint,
use_arch: any(
all(target_arch = "aarch64", target_feature = "neon"),
all(target_arch = "aarch64", target_feature = "neon", not(target_abi = "softfloat")),
all(target_arch = "wasm32", intrinsics_enabled),
),
args: x,
Expand Down
4 changes: 2 additions & 2 deletions libm/src/math/sqrt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ pub fn sqrtf(x: f32) -> f32 {
select_implementation! {
name: sqrtf,
use_arch: any(
all(target_arch = "aarch64", target_feature = "neon"),
all(target_arch = "aarch64", target_feature = "neon", not(target_abi = "softfloat")),
all(target_arch = "wasm32", intrinsics_enabled),
target_feature = "sse2"
),
Expand All @@ -33,7 +33,7 @@ pub fn sqrt(x: f64) -> f64 {
select_implementation! {
name: sqrt,
use_arch: any(
all(target_arch = "aarch64", target_feature = "neon"),
all(target_arch = "aarch64", target_feature = "neon", not(target_abi = "softfloat")),
all(target_arch = "wasm32", intrinsics_enabled),
target_feature = "sse2"
),
Expand Down
Loading