fix an if statement that can be collapsed #917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
force-pushed
the
fix-clippy-libm
branch
2 times, most recently
from
ad4cea7 to
6ab76ee
Compare
|
Actually, would you mind doing the suggested fix? It might build on stable but there isn't any reason it has to, I'd love start using let chains anyway. |
folkertdev
force-pushed
the
fix-clippy-libm
branch
from
6ab76ee to
6e86581
Compare
folkertdev
force-pushed
the
fix-clippy-libm
branch
from
6e86581 to
7922c02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is flagged by clippy in 1.87
This is the simple solution. We can use
let_chains, but currently thelibm-macroscrate looks like it builds on stable.