Skip to content

WIP: Don't assume all NaNs being type-converted are quiet NaNs #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

WIP: Don't assume all NaNs being type-converted are quiet NaNs #952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions compiler-builtins/src/float/trunc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ where
let round_mask = (src_one << (F::SIG_BITS - R::SIG_BITS)) - src_one;
let halfway = src_one << (F::SIG_BITS - R::SIG_BITS - 1);
let src_qnan = src_one << (F::SIG_BITS - 1);
let src_nan_code = src_qnan - src_one;
let src_nan_code = (src_qnan << 1) - src_one;

let dst_zero = R::Int::ZERO;
let dst_one = R::Int::ONE;
Expand All @@ -38,7 +38,7 @@ where
let overflow: F::Int = overflow_exponent << F::SIG_BITS;

let dst_qnan = R::Int::ONE << (R::SIG_BITS - 1);
let dst_nan_code = dst_qnan - dst_one;
let dst_nan_code = (dst_qnan << 1) - dst_one;

let sig_bits_delta = F::SIG_BITS - R::SIG_BITS;
// Break a into a sign and representation of the absolute value.
Expand Down Expand Up @@ -71,7 +71,6 @@ where
// Cast before shifting to prevent overflow.
let dst_inf_exp: R::Int = dst_inf_exp.cast();
abs_result = dst_inf_exp << R::SIG_BITS;
abs_result |= dst_qnan;
abs_result |= dst_nan_code & ((a_abs & src_nan_code) >> (F::SIG_BITS - R::SIG_BITS)).cast();
} else if a_abs >= overflow {
// a overflows to infinity.
Expand Down
Loading